Skip to content

evp_fetch: add freeze option#80

Closed
npajkovsky wants to merge 1 commit into
openssl:mainfrom
npajkovsky:freeze-evp-fetch
Closed

evp_fetch: add freeze option#80
npajkovsky wants to merge 1 commit into
openssl:mainfrom
npajkovsky:freeze-evp-fetch

Conversation

@npajkovsky

Copy link
Copy Markdown

$ ./evp_fetch -f CIPHER:AES-128-GCM 64 -F
Average time per fetch call: 1.244238us
$ ./evp_fetch -f CIPHER:AES-128-GCM 64
Average time per fetch call: 23.303556us

./evp_fetch -f MD:SHA2-256 64 -F
Average time per fetch call: 1.197693us
$ ./evp_fetch -f MD:SHA2-256 64
Average time per fetch call: 24.295191us

@jogme jogme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@andrewkdinh andrewkdinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update README.md

Comment thread source/evp_fetch.c Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs updating

@andrewkdinh

Copy link
Copy Markdown
Contributor

@nikolapajkovsky btw, I created an issue to fix the ssl_poll_perf issue in CI: openssl/project#1882. I will create a dedicated PR to fix it

@jogme

jogme commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

@nikolapajkovsky btw, I created an issue to fix the ssl_poll_perf issue in CI: openssl/project#1882. I will create a dedicated PR to fix it

Merged #82 . Please rebase

@npajkovsky

Copy link
Copy Markdown
Author

@jogme @andrewkdinh pushed updated version.

@andrewkdinh andrewkdinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

Comment thread source/CMakeLists.txt Outdated
evp_fetch "" "" "-q"
CACHE STRING "Post-quantum option for evp_fetch")
set(run_evp_fetch_freeze
evp_fetch "" "" "-f"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
evp_fetch "" "" "-f"
evp_fetch "" "" "-F"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

  $ ./evp_fetch -f  CIPHER:AES-128-GCM 64 -F
  Average time per fetch call: 1.244238us
  $ ./evp_fetch -f  CIPHER:AES-128-GCM 64
  Average time per fetch call: 23.303556us

  ./evp_fetch -f MD:SHA2-256 64 -F
  Average time per fetch call: 1.197693us
  $ ./evp_fetch -f MD:SHA2-256 64
  Average time per fetch call: 24.295191us

Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
npajkovsky pushed a commit that referenced this pull request Mar 4, 2026
  $ ./evp_fetch -f  CIPHER:AES-128-GCM 64 -F
  Average time per fetch call: 1.244238us
  $ ./evp_fetch -f  CIPHER:AES-128-GCM 64
  Average time per fetch call: 23.303556us

  ./evp_fetch -f MD:SHA2-256 64 -F
  Average time per fetch call: 1.197693us
  $ ./evp_fetch -f MD:SHA2-256 64
  Average time per fetch call: 24.295191us

Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Wed Mar  4 14:52:41 2026
(Merged from #80)
@npajkovsky

Copy link
Copy Markdown
Author

Merged, thanks

@npajkovsky npajkovsky closed this Mar 4, 2026
Sashan pushed a commit to Sashan/perftools that referenced this pull request Mar 8, 2026
  $ ./evp_fetch -f  CIPHER:AES-128-GCM 64 -F
  Average time per fetch call: 1.244238us
  $ ./evp_fetch -f  CIPHER:AES-128-GCM 64
  Average time per fetch call: 23.303556us

  ./evp_fetch -f MD:SHA2-256 64 -F
  Average time per fetch call: 1.197693us
  $ ./evp_fetch -f MD:SHA2-256 64
  Average time per fetch call: 24.295191us

Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Wed Mar  4 14:52:41 2026
(Merged from openssl#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants